Change type for volumeMount in CRD to VolumeMount #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkujawa-sumo
force-pushed
the
kk-volume-mount-type
branch
3 times, most recently
from
d052f59
to
10e5edb
Compare
kkujawa-sumo
force-pushed
the
kk-volume-mount-type
branch
from
10e5edb
to
75538f7
Compare
kkujawa-sumo
force-pushed
the
kk-volume-mount-type
branch
10 times, most recently
from
1b3552c
to
de2363a
Compare
operator: adjust code to volumeMount type tests: extend tests to cover volume mount options tests: add MountPath to all TailingSidecar resources MountPath is required parameter for VolumeMount tests: add target to Makefile and template to test VolumeMount update
with reinvocationPolicy set to ifNeeded kube-apiserver calls mutating webhook multiple times but changes from previous call were not applied
kkujawa-sumo
force-pushed
the
kk-volume-mount-type
branch
2 times, most recently
from
27fb5d9
to
972c658
Compare
operator/tests/test-update.sh
Outdated
| @@ -9,11 +9,11 @@ readonly NAMESPACE="tailing-sidecar-system" | |||
| readonly TIME=300 | |||
|
|
|||
| wait_for_all_pods_running ${NAMESPACE} ${TIME} | |||
| echo "$(kubectl describe pods -n ${NAMESPACE})" | |||
There was a problem hiding this comment.
Is the echo needed here? Why not just do kubectl describe pods -n ${NAMESPACE}?
There was a problem hiding this comment.
It is not needed. Thanks for catching this!
andrzej-stencel
approved these changes
Apr 9, 2021
kkujawa-sumo
force-pushed
the
kk-volume-mount-type
branch
from
972c658
to
64b19ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
crd: change type for volumeMount to VolumeMount
operator: adjust code to volumeMount type
tests: extend tests to cover volume mount options
tests: add MountPath to all TailingSidecar resources
MountPath is required parameter for VolumeMount
tests: add target to Makefile and template to test VolumeMount update
chart,templates: set
reinvocationPolicytoNever, withreinvocationPolicyset toifNeededkube-apiserver callsmutating webhook multiple times but changes from previous call were not applied
tests: add kubectl describe command for easier debugging of broken tests
Related to #55