operator: add explicit non blocking handling of Pod deletion #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzej-stencel
approved these changes
Apr 2, 2021
pmalek-sumo
reviewed
Apr 2, 2021
| @@ -62,6 +63,10 @@ type PodExtender struct { | |||
|
|
|||
| // Handle handles requests to create/update Pod and extends it by adding tailing sidecars | |||
| func (e *PodExtender) Handle(ctx context.Context, req admission.Request) admission.Response { | |||
| if req.Operation == admv1.Delete { | |||
There was a problem hiding this comment.
Please add a more descriptive comment about the situation when this happens and what this if is trying to solve
Trying to change volumeMount type from string to VolumeMount from k8s.io/api/core/v1 observed that when Pod is modified through kubectl apply --force deletion hangs
kkujawa-sumo
force-pushed
the
kk-add-delete-handling
branch
from
90e57d9
to
5bb8b25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to change volumeMount type from string to
VolumeMount from k8s.io/api/core/v1 observed that
when Pod is modified through kubectl apply --force deletion hangs
Related to #55 and #119