Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update do_insert in MongoDB tab #2011

Conversation

Lalith-Sagar-Devagudi
Copy link
Contributor

Description

This update introduces two significant improvements to the do_insert function within the MongoDB tab of the superduperdb package:

  1. Previously, the datatype check within the conditional statements was incomplete, leading to potential issues when non-string data types were passed. I've fixed this by importing the DataType class and explicitly checking if the datatype is an instance of DataType.

  2. I've modified the function signature of do_insert to include schema as an optional parameter with a default value of None.

Related Issues

[TEST-USE] Transfer learning #1967

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make unit-testing and make integration-testing successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

@kartik4949 kartik4949 merged commit 2bfef00 into superduper-io:main Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants