Refactor/document encode #2160
Merged
Refactor/document encode #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jieguangzhou
force-pushed
the
refactor/document-encode
branch
2 times, most recently
from
1908c62
to
f481bdd
Compare
jieguangzhou
commented
Jun 12, 2024
superduperdb/base/document.py
Outdated
Comment on lines
416
to
419
| # TODO: How about the lazy loading of the artifact? | ||
| # Should this function return a callback function for getting the artifact? | ||
| def _get_artifact(db, path): | ||
| return db.artifact_store.get_bytes(path) |
There was a problem hiding this comment.
@blythed The current logic for fetching bytes from the database is handled in the artifact, which parses the reference and then retrieves the bytes. Please confirm.
There was a problem hiding this comment.
Yes I like the callback approach. We could use this approach also for doing downloadable artifacts at some point.
There was a problem hiding this comment.
So you would "forward" a getter to the Artifact
jieguangzhou
commented
Jun 12, 2024
superduperdb/components/datatype.py
Outdated
Comment on lines
545
to
549
| # TODO: Need to sort out the initialization of the artifact | ||
| # 1. Use x(bytes) and schema for decoding. (bytes from _blobs) | ||
| # 2. Use x(reference) and schema for decoding. | ||
| # 3. use _blob(reference) for decoding. (bytes from _blobs) | ||
| # 4. use _blob(bytes) for decoding |
There was a problem hiding this comment.
@blythed Please confirm.
There was a problem hiding this comment.
I think that x is the actual decoded thing (like PIL.Image) and blob is the bytes. blob can either be a reference or pure bytes, depending on the class.
jieguangzhou
force-pushed
the
refactor/document-encode
branch
from
f481bdd
to
7751bb6
Compare
jieguangzhou
commented
Jun 12, 2024
jieguangzhou
force-pushed
the
refactor/document-encode
branch
5 times, most recently
from
64579e7
to
fe2afe6
Compare
jieguangzhou
force-pushed
the
refactor/document-encode
branch
from
fe2afe6
to
a2f59cf
Compare
blythed
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Checklist
make unit_testingandmake integration-testingsuccessfully?Additional Notes or Comments