Fix/snowflake compatibility #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blythed
force-pushed
the
fix/snowflake-compatibility
branch
from
c0a3183
to
a9b7d73
Compare
There was a problem hiding this comment.
After adding this line except (NoSuchTableError, IbisError) then the UT pass
diff --git a/superduperdb/backends/ibis/data_backend.py b/superduperdb/backends/ibis/data_backend.py
index af3085ad2..bd0ec0462 100644
--- a/superduperdb/backends/ibis/data_backend.py
+++ b/superduperdb/backends/ibis/data_backend.py
@@ -5,7 +5,7 @@ from warnings import warn
import ibis
import pandas
from ibis.backends import BaseBackend
-
+from ibis.common.exceptions import IbisError
from pandas.core.frame import DataFrame
from sqlalchemy.exc import NoSuchTableError
@@ -153,7 +153,7 @@ class IbisDataBackend(BaseDataBackend):
try:
self.conn.table(f'_outputs.{predict_id}')
return True
- except NoSuchTableError:
+ except (NoSuchTableError, IbisError):
return False
a9b7d73
to
5c6a2b4
Compare
blythed
force-pushed
the
fix/snowflake-compatibility
branch
from
5c6a2b4
to
4028af1
Compare
Ah yes, thanks. This is because |
blythed
force-pushed
the
fix/snowflake-compatibility
branch
3 times, most recently
from
512d6d0
to
d2a7148
Compare
blythed
commented
Jun 18, 2024
|
|
||
| self.job_table = Table( | ||
| 'job', | ||
| 'JOB', |
There was a problem hiding this comment.
Snowflake doesn't work with lower case tables for some reason.
blythed
commented
Jun 18, 2024
| @@ -103,13 +93,6 @@ def _init_tables(self): | |||
| *component_table_args, | |||
| ) | |||
|
|
|||
| self.meta_table = Table( | |||
blythed
commented
Jun 18, 2024
|
|
||
| metadata = MetaData() | ||
| self.query_id_table = Table( |
jieguangzhou
approved these changes
Jun 18, 2024
blythed
force-pushed
the
fix/snowflake-compatibility
branch
2 times, most recently
from
cc5e912
to
503e622
Compare
blythed
force-pushed
the
fix/snowflake-compatibility
branch
from
503e622
to
46c4020
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should update
ibisfor the latest features and support. This required a few fixes, which this PR provides.