Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring sprite changing back in editor #1342

Closed
busybody42 opened this issue Feb 15, 2020 · 3 comments · Fixed by #2646
Closed

Spring sprite changing back in editor #1342

busybody42 opened this issue Feb 15, 2020 · 3 comments · Fixed by #2646
Labels
category:code involves:editor type:bug

Comments

@busybody42
Copy link
Contributor

Whenever I try to change the spring sprite to a mr jump sprite, with a newassets folder, It'll just change back as soon as I load/undo/redo the level again!
However, when I do it WITHOUT messing with the portable = true/false option, It works just fine!
Can anybody please help me?
@busybody42

This comment was marked as off-topic.

Sign in to view
@tobbi
Copy link
Member

tobbi commented Feb 17, 2020

It's not technically a bug...fixed sprites have a default sprite that gets used at any time.

@busybody42

This comment was marked as off-topic.

Sign in to view
tobbi added a commit that referenced this issue Sep 24, 2023
@tobbi
Maybe fixes #1342
49fa837
@Vankata453 Vankata453 mentioned this issue Sep 25, 2023
Closed
Vankata453 added a commit to Vankata453/supertux that referenced this issue Sep 25, 2023
@Vankata453
Check if MovingSprite type change call is initial
d956909 
Removes an old `MovingSprite::has_found_sprite()` hack, which allowed getting whether a custom sprite has been found only the first time it's called. After the first call, `m_sprite_found` always equaled to `false`.

`MovingSprite::on_type_change` now checks if the call is initial, and if so, only sets the default sprite for the type, if a custom sprite hasn't just been loaded.

Closes SuperTux#1342.
@Vankata453 Vankata453 mentioned this issue Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category:code involves:editor type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check if MovingSprite type change call is initial Vankata453/supertux
3 participants
@tobbi @busybody42 @mrkubax10