Check if MovingSprite type change call is initial
#2646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes an old `MovingSprite::has_found_sprite()` hack, which allowed getting whether a custom sprite has been found only the first time it's called. After the first call, `m_sprite_found` always equaled to `false`. `MovingSprite::on_type_change` now checks if the call is initial, and if so, only sets the default sprite for the type, if a custom sprite hasn't just been loaded. Closes SuperTux#1342.
Closed
tobbi
reviewed
Sep 25, 2023
mrkubax10
added
category:code
status:needs-review
MatusGuy
approved these changes
Dec 21, 2023
|
Can we move -1 to a constant with a proper name? |
I've replaced -1 with the |
|
@tobbi Can you re-review this one? |
tobbi
reviewed
Dec 29, 2023
mrkubax10
approved these changes
Jan 30, 2024
mrkubax10
removed
the
status:needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes an old
MovingSprite::has_found_sprite()hack, which allowed getting whether a custom sprite has been found only the first time it's called. After the first call,m_sprite_foundalways equaled tofalse.MovingSprite::on_type_changenow checks if the call is initial, and if so, only sets the default sprite for the type, if a custom sprite hasn't just been loaded.Closes #1342. Fixes #2701.