Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent tileset changes broken #2306

Closed
maxteufel opened this issue Oct 7, 2022 · 5 comments · Fixed by #2671
Closed

Recent tileset changes broken #2306

maxteufel opened this issue Oct 7, 2022 · 5 comments · Fixed by #2671

Comments

@maxteufel
Copy link
Member

The tileset changes from 2022-10-06 are seemingly broken:

screenshot cleaned

@pazkero
Copy link
Contributor

pazkero commented Oct 7, 2022

Known bug

“Known bug”

@Rusty-Box
Copy link
Member

This is less of the tiles being "broken" and more of a "tile-IDs have changed" situation. We are aware of this fact and are already at work of rebuilding most important levelsets/worldmaps with those changes!

For the main game, these include:
All Story Mode Worlds, Bonus Island I + II, Revenge In Redmond, Christmas + Halloween Special

Everything that does not come with the game (pre-installed) will be in the hands of their original creators or people from the community who wish to restore those older contrib. levels for v0.7+!

@maxteufel
Copy link
Member Author

This is less of the tiles being "broken" and more of a "tile-IDs have changed" situation. We are aware of this fact and are already at work of rebuilding most important levelsets/worldmaps with those changes!

I understood that much from the first reply. I've pinned the issue in case anyone else runs the version from git and wonders what's going on.

@Grumbel
Copy link
Member

Grumbel commented Oct 7, 2022

This is less of the tiles being "broken" and more of a "tile-IDs have changed" situation. We are aware of this fact and are already at work of rebuilding most important levelsets/worldmaps with those changes!

That sounds broken to me. Tile ids should never ever under any circumstances change. Once assigned they should be considered permanent. Anything else is just a colossal waste of time, especially when you want to support addons.

On the art side: The tiling pattern in the new tileset looks way to obvious.

@JoniG59
Copy link

JoniG59 commented Mar 26, 2023

Why is this issue closed? It's not fixed in master branch

Vankata453 added a commit that referenced this issue Dec 10, 2023
… deprecation (#2671)

**Reverts the tile IDs** in `tiles.strf` to ones, compatible with the old tile mappings, before the full tile overhaul. Any old tiles, which do not have a respective new version, are now marked as deprecated.

**Tile converters** can now be used to convert all tiles on all tilemaps in a level, from the editor. Contains two stock tile converters (0.5.x Crystal Tiles, Nightly Tiles -> Present), and a new tile conversions menu (accessible from the main level editor menu). The "Nightly Tiles" converter allows for converting from the current Nightly Builds mapping, to this new, final one. The tiles of the main menu and credits levels are converted in this PR.

Introduces **tile deprecation** and various editor locks to prevent using such tiles, as well as show whether/where such tiles are present in a level.

Additionally introduces **texture deprecation**. Any image files, containing `.deprecated` right before the extension in their filename will be used, whenever the main texture (the one, which doesn't contain the `.deprecated` part in its filename) does not exist, taking its place. Deprecated files do not show up on the file browsing menu.

-----

Huge thanks to [Semphris](https://github.com/Semphriss) for all the initial work on this, including quite a lot of tile re-mapping, organizing the full workflow, as well as the initial process of auto-generating new tile IDs and creating converters, and the implementation of the tile conversion algorithm.

Fixes #2306.
@Vankata453 Vankata453 unpinned this issue Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants