Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swimming Improvements #1704

Merged
merged 29 commits into from
May 2, 2021
Merged

Swimming Improvements #1704

merged 29 commits into from
May 2, 2021

Conversation

weluvgoatz
Copy link
Member

@weluvgoatz weluvgoatz commented Mar 18, 2021

This Pull Request fixes many if not most of the problems introduced by the inclusion of swimming into SuperTux. Please review the PR so that it can be merged when ready! Note that the graphics were not changed, as this will happen when the Tux graphics revamp is done, and many examples of improvable code were not changed in order to remain consistent until an overall code quality improvement is done.

      - Make hats work properly
	  - Simplify bigtux hitbox
	  - Better friction
	  - decrease swim jump power (cap to power)
      - hold to boost
      - remove water gravity
	  - BUGFIX: unrotate graphics when on ladder
	  - minor swimming-related walljumping fixes
	  - BUGFIX: shoot fireballs properly
	  - fix earthtux light
@weluvgoatz weluvgoatz added category:code status:needs-review Work needs to be reviewed by other people labels Mar 18, 2021
@mbernard2
Copy link
Contributor

I noticed it's easier to jump out of the water (especially in Shocking which was incredibly difficult before this PR) but it's still too difficult sometimes to reach higher platforms. Take a look :

st-shocking

If you don't have enough speed when trying to reach the platform, it's pretty much too late...

Perhaps we could give Tux a boost no matter its current velocity every time the player presses Jump while swimming ?

Or keep it as it is, but then adjust the levels to make sure they're not too hard ?

What do you guys think ?

@Zwatotem
Copy link
Member

Zwatotem commented Mar 29, 2021

When you use air flower and jump out of the water pressing the spacebar all the time Tux will start to glide, which looks extremally silly with the way his sprite is actually rotating.

@weluvgoatz weluvgoatz changed the title Swimming Revamp Swimming Improvements Mar 29, 2021
@weluvgoatz weluvgoatz added this to Characters in Icy Island Improvements Mar 29, 2021
@weluvgoatz weluvgoatz marked this pull request as draft April 18, 2021 04:21
@weluvgoatz weluvgoatz added this to the 0.7.0 milestone Apr 18, 2021
@weluvgoatz weluvgoatz marked this pull request as ready for review April 19, 2021 00:47
@weluvgoatz
Copy link
Member Author

Since this has gotten approval from RustyBox and Semphris (the two currently most active developers by far), I will merge it. Finally!

@weluvgoatz weluvgoatz merged commit cd52221 into SuperTux:master May 2, 2021
Icy Island Improvements automation moved this from Characters to Done May 2, 2021
@mrkubax10 mrkubax10 removed the status:needs-review Work needs to be reviewed by other people label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants