Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display branch name and commit hash in window title #3001

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Display branch name and commit hash in window title #3001

wants to merge 5 commits into from

Conversation

MatusGuy
Copy link
Member

@MatusGuy MatusGuy commented Jul 6, 2024 •
edited

This pull request also removes complexity in the CMake code for git querying and version.h generation.

@MatusGuy MatusGuy requested review from tobbi and Vankata453 July 6, 2024 13:47
@MatusGuy MatusGuy added priority:low type:patch status:needs-review Work needs to be reviewed by other people labels Jul 6, 2024
tobbi
tobbi requested changes Jul 16, 2024
View reviewed changes
Copy link
Member

@tobbi tobbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it display at least the base version of the game when git wasn't found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobbi tobbi tobbi approved these changes

@Vankata453 Vankata453 Awaiting requested review from Vankata453

Assignees
No one assigned
Labels
priority:low status:needs-review Work needs to be reviewed by other people type:patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MatusGuy @tobbi