[Maintainer] GitHub settings

[chdanielmueller]

Hi @kalinchernev and @drGrove

I was thinking about changing some of the repository settings and would like to get your feedback on this.

Since this project is pretty popular with over 30'000 downloads a month on npm I think it would be useful to protect the master branch. I would recommend the following settings to make sure we do not merge any faulty and unreviewed code.

Furthermore it would be cool if we could decide on a merging style. I don't really have an opinion on the merging style but if there is the option to standardize the merges it might be useful.

I am keen to hear your opinions.

Thanks,
Daniel

[kalinchernev]

Hi @chdanielmueller,
It makes sense, of course. Actually, it's a pretty popular thing to have, so I'm for it. Although not a lot of development happens from several developers on a branch at the moment, I'd even suggest that only squash merging is allowed without rebase on master.

[drGrove]

Hi @chdanielmueller,

I think that forcing tests to run is an excellent idea.

re: squash merge, This tends to be very popular and I do think it's a good idea. The only issue i see with this revolves around more than one user making changes to a PR (like @kalinchernev this isn't very likely), but this does affect Contributions. Only the opener of a PR and the person merging the commit will get the contribution.

[chdanielmueller]

I will set the settings as discussed. If there are problems with the merging style we can change that later again.

Thanks for your inputs.