Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined speech recognition class crashes the app #81

Open
BWsix opened this issue Oct 8, 2022 · 11 comments
Open

Undefined speech recognition class crashes the app #81

BWsix opened this issue Oct 8, 2022 · 11 comments

Comments

@BWsix
Copy link

BWsix commented Oct 8, 2022

Hi, my browser does not support speech recognition for some reason, and this causes the app to crash.
Maybe we can fix by not initializing the mic variable and disabling the Start Recording button?
I've already made an working patch for this issue, if this sounds okay to you, I can make a PR.
Thanks in advance!

(Below is the error message I got)
image

@Susmita-Dey
Copy link
Owner

@BWsix What browser are you using?

@BWsix
Copy link
Author

BWsix commented Oct 8, 2022

@Susmita-Dey
latest version of librewolf, a firebox fork
https://librewolf.net/

@BWsix
Copy link
Author

BWsix commented Oct 8, 2022

By the way, here's the working patch I mentioned in the issue:
https://github.com/BWsix/TextUtils/commit/cdda88f3a16b4a81fb1588ad47abca0b4a895ffe

@Susmita-Dey
Copy link
Owner

Okay.

@imaaquibali Kindly check this

@BWsix
Copy link
Author

BWsix commented Oct 8, 2022

Maybe we can fix by not initializing the mic variable and disabling the Start Recording button?

Oops, I made a writing mistake here. This line should be:

Maybe we can fix by not initializing the mic variable and disabling the Start Recording button if speech recognition is not supported by the browser?

@imaaquibali
Copy link
Collaborator

@Susmita-Dey ok

@Susmita-Dey
Copy link
Owner

@Susmita-Dey ok

Check the patch he mentioned. I never came across this kind of thing. Not sure about it.

@BWsix
Copy link
Author

BWsix commented Oct 8, 2022

Thank you!

@imaaquibali
Copy link
Collaborator

Don't wo

@Susmita-Dey ok

Check the patch he mentioned. I never came across this kind of thing. Not sure about it.

Don't worry about it.

@imaaquibali
Copy link
Collaborator

@BWsix which browser are you using?

@BWsix
Copy link
Author

BWsix commented Oct 8, 2022

@Susmita-Dey latest version of librewolf, a firebox fork https://librewolf.net/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants