-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from LlamaKit to antitypical/Result #43
Conversation
Gonna close this until antitypical/Result#29 is merged and released. |
antitypical/Result#29 has been merged |
This is ready to go now. ✨ |
} | ||
|
||
let repository = Repository(pointer) | ||
return success(repository) | ||
return Result.success(repository) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also write .success
here, if that would be more agreeable. (I don’t have strong feelings either way myself.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'll stick with Result.success
for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Just the one comment which I’ll defer to you on. Merge away if you’d rather not address it in this PR/at all! |
Switch from LlamaKit to antitypical/Result
Fixes #41.