#nodependencies

[robrix]

Fixes #28.

[robrix]

Ready for review.

[rnapier]

👍

[robrix]

@jspahrsummers Any concerns with this approach?

[robrix]

It occurs to me we could make Box private:

• make a private ResultState enum with analysis and nothing else
• make Result a public struct with the real API

Then, since Box isn’t exposed by public cases, it has no references in public API at all, and could be private.

[jspahrsummers]

💯 All of the above sounds awesome. Thanks @robrix!

Hiding the Result cases might make pattern matching slightly more difficult, but Box kind of impaired that anyways (since you can't match through a box, IIRC). And maybe we could implement a custom ~=? Not sure how that works.

[robrix]

Correct: you can’t match through anything but an enum or tuple. To the best of my knowledge, ~= is limited to pass/fail, so that wouldn’t allow us to destructure, but we could maybe match against expected error/success values; and analysis recovers destructuring.

Gonna hide Box away now.

[robrix]

Alright, it’s done 🀄

[jspahrsummers]

[mdiep]

Can we get a release with this change? 😁

[robrix]

@mdiep 👍

[robrix]

@mdiep: https://github.com/antitypical/Result/releases/tag/0.3

[mdiep]

Thank you! 🙏

[robrix]

🙇 you’re welcome!