Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PHP 7.4 syntax #249

Merged
merged 5 commits into from
Sep 16, 2021
Merged

Use PHP 7.4 syntax #249

merged 5 commits into from
Sep 16, 2021

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Sep 6, 2021

Related to Sylius/Sylius#12891

@GSadee GSadee added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Sep 6, 2021
@GSadee GSadee requested a review from a team as a code owner September 6, 2021 11:14
@GSadee GSadee mentioned this pull request Sep 6, 2021
10 tasks

/** @var ShowPageInterface */
private $showPage;
private \Tests\Sylius\InvoicingPlugin\Behat\Page\Admin\Invoice\ShowPageInterface $showPage;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be just ShowPageInterface

@Zales0123 Zales0123 merged commit e3457ca into Sylius:master Sep 16, 2021
@Zales0123
Copy link
Member

Thanks, Grzegorz! 🥇

@GSadee GSadee deleted the php-7.4-syntax branch September 16, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants