[CoreBundle] oauth user provider fix #10197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kboduch
changed the title
|
Please review this PR, unless UserOAuth is completely broken. Ping @lchrusciel @Zales0123 |
Zales0123
added
the
Potential Bug
|
Can someone check this PR please ? It needs to be fixed |
lchrusciel
approved these changes
Mar 25, 2019
pamil
approved these changes
Mar 25, 2019
|
Thanks, Krzysztof! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is not the final form/location of the test. In fact, I wasn't sure where to put it - suggestion are welcome. But it serves its purpose, it proves oAuth User Provider is broken as described in #10196.
Later this day I will provide the fix.