Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bulk actions #10477

Merged
merged 2 commits into from
Jul 1, 2019
Merged

Improve bulk actions #10477

merged 2 commits into from
Jul 1, 2019

Conversation

kulczy
Copy link
Member

@kulczy kulczy commented Jun 28, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

ezgif-1-8f2e097a3241

@kulczy kulczy requested a review from a team as a code owner June 28, 2019 14:35
@Zales0123 Zales0123 added Admin AdminBundle related issues and PRs. UX Issues and PRs aimed at improving User eXperience. labels Jul 1, 2019
@lchrusciel lchrusciel merged commit cd3c71f into Sylius:master Jul 1, 2019
@lchrusciel
Copy link
Member

Thanks, Szymon! 🥇

@dbr031
Copy link

dbr031 commented Jul 6, 2019

Neat! Perhaps not the best place to post feedback, but I'd recommend adding support for the lesser known indeterminate checkbox state on the $checkboxAll element: The indeterminate prop would be true when only some (but not all) $checkboxes are checked. It wouldn't add any new functionality, but improve overall visual feedback.
A little more information on the third indeterminate checkbox state can be found e.g. on CSS-tricks.
We have yet to test Sylius for ourselves, but I can look into opening a PR perhaps later this month. Feel free to beat us to it though, if you think this would be useful.

@kulczy kulczy deleted the bulk-button branch April 4, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin AdminBundle related issues and PRs. UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants