Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Minor fixes customer group validation form #10492

Merged
merged 1 commit into from
Jul 4, 2019

Conversation

Tomanhez
Copy link
Contributor

@Tomanhez Tomanhez commented Jul 3, 2019

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

Before:
Screenshot 2019-07-03 at 11 42 28

After:
Screenshot 2019-07-03 at 11 44 48

@Tomanhez Tomanhez requested a review from a team as a code owner July 3, 2019 09:48
@pamil pamil added the Potential Bug Potential bugs or bugfixes, that needs to be reproduced. label Jul 4, 2019
@pamil pamil force-pushed the customer-group-validation-form-fixes branch from 1cc2e2b to c22655f Compare July 4, 2019 06:23
@pamil pamil changed the base branch from master to 1.4 July 4, 2019 06:23
@pamil
Copy link
Contributor

pamil commented Jul 4, 2019

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "customer-group-validation-form-fixes" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@pamil pamil closed this Jul 4, 2019
@pamil pamil reopened this Jul 4, 2019
@pamil pamil merged commit 911fd2e into Sylius:1.4 Jul 4, 2019
@pamil
Copy link
Contributor

pamil commented Jul 4, 2019

Thanks, Tomasz! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants