Fix typo and imporve error message #12687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dantleech
commented
Jun 2, 2021
•
dantleech
commented
| Q | A |
|---|---|
| Branch? | 1.9 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
dantleech
force-pushed
the
fix-typo-improve-error-message
branch
from
54c5592
to
0d47513
Compare
dantleech
commented
Jun 2, 2021
| @@ -131,7 +131,10 @@ private function getLocaleCode(?string $localeCode, ChannelInterface $channel): | |||
| } | |||
|
|
|||
| if (!$this->hasLocaleWithLocaleCode($channel, $localeCode)) { | |||
| throw new \InvalidArgumentException('Choosen localeCode doesn\'t exist.'); | |||
| throw new \InvalidArgumentException(sprintf( | |||
| 'Cannot pick up cart, locale code "%s" does not exist.', | |||
There was a problem hiding this comment.
Choosen should have been Chosen, but I changed the message to be a bit more explict.
GSadee
approved these changes
Jun 14, 2021
|
Thank you, @dantleech! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.