[CatalogPromotion] Refactor to not listen on Doctrine events #13152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Sep 29, 2021
GSadee
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
GSadee
added
the
Enhancement
GSadee
force-pushed
the
remove-doctrine-listener-for-catalog-promotion
branch
from
4a5b2f9
to
360e1b5
Compare
Zales0123
approved these changes
Sep 29, 2021
| @@ -29,25 +28,11 @@ public function __construct(MessageBusInterface $eventBus) | |||
| $this->eventBus = $eventBus; | |||
| } | |||
|
|
|||
| public function postPersist(LifecycleEventArgs $args): void | |||
| public function update(GenericEvent $event): void | |||
There was a problem hiding this comment.
As it can be used for both creation and update, maybe just __invoke()? Of dispatchCatalogPromotionUpdateEvent? 🤷
|
Thank you, Grzegorz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.