Add Support for Symfony 5.4 #13339

AdamKasp · 2021-11-29T09:27:45Z

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
License	MIT

config/packages/security.yaml

lchrusciel · 2021-11-30T10:41:58Z

src/Sylius/Bundle/ApiBundle/Controller/UploadAvatarImageAction.php

@@ -57,7 +57,7 @@ public function __invoke(Request $request): ImageInterface
        $image->setFile($file);

        /** @var string $ownerIri */
-        $ownerIri = $request->get('owner');
+        $ownerIri = $request->request->get('owner');


This could be considered as BC-Break, but I'm fine with that. Can we add a note about it?

we have @experimental on the entire apiBundle so IMO it isn't BC-break, but ofc I will add a note to apiUpgrade file

lchrusciel · 2021-11-30T10:42:07Z

src/Sylius/Bundle/ApiBundle/Controller/Payment/GetPaymentConfiguration.php

@@ -38,7 +38,10 @@ public function __construct(
    public function __invoke(Request $request): JsonResponse
    {
        /** @var PaymentInterface|null $payment */
-        $payment = $this->paymentRepository->findOneByOrderToken($request->get('paymentId'), $request->get('id'));
+        $payment = $this->paymentRepository->findOneByOrderToken(
+            $request->attributes->get('paymentId'),


This could be considered as BC-Break, but I'm fine with that. Can we add a note about it?

we have @experimental on the entire apiBundle so IMO it isn't BC-break, but ofc I will add a note to apiUpgrade file

lchrusciel · 2021-11-30T10:42:52Z

src/Sylius/Bundle/CoreBundle/Controller/ProductTaxonController.php

+        }
+
+        if ($request->query->has($key)) {
+            return $request->query->all()[$key];


Why not this way?

Suggested change

return $request->query->all()[$key];

return $request->query->get($key);

src/Sylius/Bundle/CoreBundle/Controller/ProductTaxonController.php

lchrusciel · 2021-11-30T10:48:23Z

src/Sylius/Bundle/CoreBundle/Controller/ProductVariantController.php

+     * @deprecated This function will be removed in Sylius 2.0, since Symfony 5.4, use explicit input sources instead
+     * based on Symfony\Component\HttpFoundation\Request::get
+     */
+    private function getParameterFromRequest(Request $request, string $key)


I'm wondering if we shouldn't port it down to ResourceBundle

it is temporary logic, I am not sure if we need to make bigger refactor of it.

this "temporary" logic will be with us for a long time

👍 for moving it to ResourceBundle. However, to not stop this PR for too long, I suggest we merge it and proceed with ResourceBundle changes parallelly 🖖

tests/Controller/AdminProductAjaxTest.php

lchrusciel · 2021-12-01T11:39:55Z

src/Sylius/Bundle/CoreBundle/Controller/ProductVariantController.php

+     * @deprecated This function will be removed in Sylius 2.0, since Symfony 5.4, use explicit input sources instead
+     * based on Symfony\Component\HttpFoundation\Request::get
+     */
+    private function getParameterFromRequest(Request $request, string $key)


this "temporary" logic will be with us for a long time

src/Sylius/Behat/Service/SecurityService.php

src/Sylius/Bundle/CoreBundle/Security/UserImpersonator.php

GSadee · 2021-12-02T07:20:42Z

src/Sylius/Bundle/ProductBundle/Controller/ProductSlugController.php

+    private ?SlugGeneratorInterface $slugGenerator;
+
+    public function __construct(?SlugGeneratorInterface $slugGenerator = null)
+    {
+        $this->slugGenerator = $slugGenerator;
+
+        if ($this->slugGenerator === null) {
+            @trigger_error(sprintf('Not passing a $slugGenerator to %s constructor is deprecated since Sylius 1.11 and will be prohibited in Sylius 2.0.', self::class), \E_USER_DEPRECATED);
+        }
+    }


Why did you add this service in this PR?

because

in Symfony 5.4 function get is deprecated

GSadee · 2021-12-03T05:54:54Z

Thank you, Adam! 🎉

This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? |yes | BC breaks? | no | Deprecations? | no | License | MIT  Commits ------- 28a02a6 Prepare Sylius for support Symfony 5.4 d2c39e4 remove usage of symfony internal method fef6243 bump symofny verion from 5.4.0-RC1 to 5.4 6339528 update argument in UsernamePasswordToken 2964e0e make workorounds over deprecated method in symofny 5.4

…e, lchrusciel) This PR was merged into the 1.10 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.10 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | Backport of #13339 and #13358, fixes Sylius/Sylius-Standard#630 | License | MIT Let's bring Sf5.4 support to Sylius 1.10. This way, current users will benefit from Symfony 5.4 with current installations. I'm considering it as a bug-fix, as it is already possible to install this version according to our composer.json. What is more, it will make it possible to migrate first to Sf5.4 and then upgrade to Sylius 1.11.  Commits ------- 860c3e8 [Maintanance] add conflict 71e4fd6 feature #13339 Add Support for Symfony 5.4 (AdamKasp) 860399f [Minor] Fix CONFLICT.md lining 5937ebb [Maintenance] Conflict with Symfony ^6.0

* 1.10: Minimize number of build for packages [Maintenance] Conflict with Symfony ^6.0 [Minor] Fix CONFLICT.md lining feature #13339 Add Support for Symfony 5.4 (AdamKasp) [Maintanance] add conflict Corrections for adding a field to the response

AdamKasp added the Maintenance CI configurations, READMEs, releases, etc. label Nov 29, 2021

AdamKasp requested a review from a team as a code owner November 29, 2021 09:27

probot-autolabeler bot added Admin AdminBundle related issues and PRs. API APIs related issues and PRs. Shop ShopBundle related issues and PRs. labels Nov 29, 2021

Prepare Sylius for support Symfony 5.4

28a02a6

AdamKasp force-pushed the bump-up-symfony-5.4 branch 2 times, most recently from 37c87b5 to d50d4dd Compare November 29, 2021 14:43

remove usage of symfony internal method

d2c39e4

AdamKasp force-pushed the bump-up-symfony-5.4 branch 5 times, most recently from d5f3ef4 to 2f541d5 Compare November 30, 2021 10:03

AdamKasp commented Nov 30, 2021

View reviewed changes

config/packages/security.yaml Outdated Show resolved Hide resolved

bump symofny verion from 5.4.0-RC1 to 5.4

fef6243

AdamKasp force-pushed the bump-up-symfony-5.4 branch from 2f541d5 to fef6243 Compare November 30, 2021 10:16

lchrusciel reviewed Nov 30, 2021

View reviewed changes

update argument in UsernamePasswordToken

6339528

AdamKasp force-pushed the bump-up-symfony-5.4 branch from eb3b56a to d8827c4 Compare November 30, 2021 13:38

mbabker reviewed Nov 30, 2021

View reviewed changes

tests/Controller/AdminProductAjaxTest.php Outdated Show resolved Hide resolved

AdamKasp force-pushed the bump-up-symfony-5.4 branch from d8827c4 to fcc5abe Compare December 1, 2021 07:54

AdamKasp changed the title ~~Prepare Sylius for support Symfony 5.4~~ Add Support for Symfony 5.4 Dec 1, 2021

lchrusciel approved these changes Dec 1, 2021

View reviewed changes

GSadee reviewed Dec 2, 2021

View reviewed changes

make workorounds over deprecated method in symofny 5.4

2964e0e

AdamKasp force-pushed the bump-up-symfony-5.4 branch from fcc5abe to 2964e0e Compare December 2, 2021 11:12

GSadee approved these changes Dec 3, 2021

View reviewed changes

GSadee merged commit 6191f36 into Sylius:master Dec 3, 2021

Zales0123 mentioned this pull request Dec 6, 2021

Require Symfony 5.3 for Sylius 1.10 Sylius/Sylius-Standard#631

Closed

lchrusciel mentioned this pull request Dec 6, 2021

Add Symfony 5.4 support for Sylius 1.10 #13357

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Support for Symfony 5.4 #13339

Add Support for Symfony 5.4 #13339

AdamKasp commented Nov 29, 2021

lchrusciel Nov 30, 2021

AdamKasp Nov 30, 2021

lchrusciel Nov 30, 2021

AdamKasp Nov 30, 2021

lchrusciel Nov 30, 2021

lchrusciel Nov 30, 2021

AdamKasp Nov 30, 2021

lchrusciel Dec 1, 2021

Zales0123 Dec 2, 2021

lchrusciel Dec 1, 2021

GSadee Dec 2, 2021

AdamKasp Dec 2, 2021

GSadee commented Dec 3, 2021

	return $request->query->all()[$key];
	return $request->query->get($key);

Add Support for Symfony 5.4 #13339

Add Support for Symfony 5.4 #13339

Conversation

AdamKasp commented Nov 29, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GSadee commented Dec 3, 2021