Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] add info about hardcoded translations #13472

Merged
merged 3 commits into from
Jan 14, 2022

Conversation

SirDomin
Copy link
Contributor

Q A
Branch? 1.11
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Inform about hardcoded keys in catalog promotion scopes/actions translations

@SirDomin SirDomin added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Jan 12, 2022
@SirDomin SirDomin requested a review from a team as a code owner January 12, 2022 09:02
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats sentence is quite long, so I would recommend split it into at least two. But I don't have strong need for it

@SirDomin SirDomin force-pushed the mention-hardcoded-translations branch from 171bd47 to 2a0d6d9 Compare January 13, 2022 13:31
@Zales0123 Zales0123 merged commit b7ddf21 into Sylius:1.11 Jan 14, 2022
@Zales0123
Copy link
Member

Thank you, @SirDomin! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants