Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Behat] added context to manage non-collection subresources #13801

Merged

Conversation

emmanuel-averty
Copy link
Contributor

Q A
Branch? 1.10
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
License MIT

In order to use Sylius with the next API Platform release (2.7), I added the ability to test API resources which contains non-collection sub-resources (i.e. channel).
This patch seems to be useless with API Platform 2.6, but is mandatory for API Platform 2.7.

@emmanuel-averty emmanuel-averty requested a review from a team as a code owner March 28, 2022 12:35
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Emmanuel!

Thanks a lot for preparing us for an upgrade and welcome among Sylius contributors :)

@lchrusciel lchrusciel added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). DX Issues and PRs aimed at improving Developer eXperience. API APIs related issues and PRs. labels Mar 28, 2022
@lchrusciel lchrusciel merged commit 28b28e3 into Sylius:1.10 Mar 28, 2022
@lchrusciel
Copy link
Member

Thanks, Emmanuel! 🥇

@emmanuel-averty emmanuel-averty deleted the behat_context_for_subresource branch March 29, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API APIs related issues and PRs. DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants