[Resource] Integrated Translations #4256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjedrzejewski
added
Enhancement
| @@ -1,6 +1,10 @@ | |||
| CHANGELOG | |||
| ========= | |||
|
|
|||
| ### v0.17.0 | |||
|
|
|||
| * Integrated TranslationBundle. | |||
There was a problem hiding this comment.
Merged with TranslationBundle.
NoResponseMate
force-pushed
the
move-translation-to-resource
branch
3 times, most recently
from
ec58c4d
to
4ee2049
Compare
NoResponseMate
force-pushed
the
move-translation-to-resource
branch
2 times, most recently
from
40596b3
to
056b8d1
Compare
| @@ -82,7 +82,7 @@ private function addResourcesSection(ArrayNodeDefinition $node) | |||
| ->scalarNode('model')->defaultValue(Archetype::class)->cannotBeEmpty()->end() | |||
| ->scalarNode('interface')->defaultValue(ArchetypeInterface::class)->cannotBeEmpty()->end() | |||
| ->scalarNode('controller')->defaultValue(ResourceController::class)->cannotBeEmpty()->end() | |||
| ->scalarNode('repository')->defaultValue(TranslatableResourceRepository::class)->cannotBeEmpty()->end() | |||
| ->scalarNode('repository')->defaultValue(TranslatableRepository::class)->cannotBeEmpty()->end() | |||
There was a problem hiding this comment.
Repository should not have default value at all. It is fixed in #3854. This logic should be placed under drivers folder in resource of bundle.
|
I think it should be based on #3854, because |
NoResponseMate
force-pushed
the
move-translation-to-resource
branch
6 times, most recently
from
d85a904
to
3ddb3be
Compare
| @@ -28,7 +29,7 @@ | |||
| * @author Alexandre Bacco <alexandre.bacco@gmail.com> | |||
| * @author Saša Stamenković <umpirsky@gmail.com> | |||
| */ | |||
| class NumberListener | |||
| class NumberListener implements NumberListenerInterface | |||
There was a problem hiding this comment.
Listeners should not use interfaces. :)
|
@NeverResponse Requires rebasing after merge of #3854. |
NoResponseMate
force-pushed
the
move-translation-to-resource
branch
from
3ddb3be
to
81b3da9
Compare
pjedrzejewski
pushed a commit
that referenced
this pull request
Mar 9, 2016
[Resource] Integrated Translations
|
Thanks Jasiek! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3854