Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master variant price should not show #121

Closed
PaddyLock opened this issue May 30, 2013 · 4 comments
Closed

Master variant price should not show #121

PaddyLock opened this issue May 30, 2013 · 4 comments
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced. UX Issues and PRs aimed at improving User eXperience.

Comments

@PaddyLock
Copy link

Hi, when I have created a product with a master variant I have to give it a price (which could be anything), even if I need to create variants which all have different prices to the master. By creating the variants the master price becomes redundant. However, this price still shows on the frontend homepage view, which in my case it shouldn't. Is this an oversight or a feature?

thanks

@pjedrzejewski
Copy link
Member

This is a mistake indeed. It should not be displayed. If product has variants, the master variants serves as a template... so this price is the default one when creating new variants.

@QuingKhaos
Copy link
Contributor

@pjedrzejewski ping

It's showing the price from the master variant in the product list. In the product detail (frontend), no price is shown. Neither the price from the master variant nor the price from the selected variant.

@stloyd
Copy link
Contributor

stloyd commented Oct 3, 2014

I guess we could fix this on product list with something like:

  • sort variants by default using price,
  • on list for product with variants use code like:
Starting from {{ product.variants.first.price|sylius_price }}

I guess that issue with price not being shown on details of the product is fixed now.

@coudenysj
Copy link
Contributor

I think this is only partially fixed. There are still prices shown in the overview
sylius_-_modern_ecommerce_for_symfony2

but on the detail page this price is not available
sylius_-_modern_ecommerce_for_symfony2

pamil pushed a commit to pamil/Sylius that referenced this issue Mar 21, 2016
The copy right was not up to date...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced. UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Development

No branches or pull requests

5 participants