Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce arrow functions from PHP 7.4 #13268

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

Zales0123
Copy link
Member

Q A
Branch? 1.10
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Every Bundle except the ApiBundle (as it's a huge one 馃拑). Let's use PHP 7.4 on its finest 馃殌

@Zales0123 Zales0123 added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). DX Issues and PRs aimed at improving Developer eXperience. labels Nov 2, 2021
@Zales0123 Zales0123 requested a review from a team as a code owner November 2, 2021 12:43
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Nov 2, 2021
@lchrusciel lchrusciel merged commit dcf8215 into Sylius:1.10 Dec 15, 2021
@Zales0123 Zales0123 deleted the arrow-functions branch January 10, 2022 09:56
AdamKasp added a commit that referenced this pull request Jun 1, 2022
This PR was merged into the 1.11 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.11|
| Bug fix?        | no                                                       |
| New feature?    | no                                                       |
| BC breaks?      | no                                                       |
| Deprecations?   | no|
| Related tickets | continuation of #12891 and #13268                      |
| License         | MIT                                                          |

<!--
 - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

5477cd0 [Behat] Refactor to use PHP 7.4 syntax
e3961b0 [Behat] Fix CS after introducing PHP 7.4 syntax
eb127a4 [Behat] Fix typehint of mink parameters property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin AdminBundle related issues and PRs. DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants