feature #89 Allow PHP8 (plozmun)

This PR was merged into the 2.1-dev branch. Discussion ---------- Related to Sylius/Sylius#12298 and #86 Commits ------- 1037e85 Allow PHP8
Sylius · Mar 19, 2021 · 22cfe19 · 22cfe19
2 parents 0dc0bd3 + 1037e85
commit 22cfe19
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 12 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -55,16 +55,14 @@ jobs:
                         symfony: 5.1.*
                         symfony-contracts: ^2.0
                         twig: 3.*
-#                    -
-#                        php: 8.0
-#                        symfony: 4.4.*
-#                        twig: 2.*
-#                        composer-flags: "--ignore-platform-req=php"
-#                    -
-#                        php: 8.0
-#                        symfony: 5.1.*
-#                        twig: 3.*
-#                        composer-flags: "--ignore-platform-req=php"
+                    -
+                        php: 8.0
+                        symfony: 4.4.*
+                        twig: 2.*
+                    -
+                        php: 8.0
+                        symfony: 5.1.*
+                        twig: 3.*
 
         steps:
             -
@@ -96,7 +94,7 @@ jobs:
 
             -
                 name: Install dependencies
-                run: composer update ${{ matrix.composer-flags }}
+                run: composer update
 
             -
                 name: Run analysis

diff --git a/composer.json b/composer.json
@@ -23,7 +23,7 @@
         }
     ],
     "require": {
-        "php": "^7.3",
+        "php": "^7.3 || ^8.0",
         "symfony/asset": "^4.4 || ^5.1",
         "symfony/config": "^4.4 || ^5.1",
         "symfony/console": "^4.4 || ^5.1",

diff --git a/phpspec.yml.dist b/phpspec.yml.dist
@@ -3,3 +3,5 @@ suites:
         namespace: Sylius\Bundle\ThemeBundle
         psr4_prefix: Sylius\Bundle\ThemeBundle
         src_path: .
+
+runner.maintainers.errors.level: 256
diff --git a/spec/Asset/Installer/LegacyAssetsProviderSpec.php b/spec/Asset/Installer/LegacyAssetsProviderSpec.php
@@ -43,6 +43,11 @@ function let(
         $this->beConstructedWith($assetsProvider, $kernel, $themeHierarchyProvider);
     }
 
+    function it_should_trigger_deprecated_warning_during_instantiation(): void
+    {
+        $this->shouldTrigger(\E_USER_DEPRECATED)->duringInstantiation();
+    }
+
     function it_is_an_assets_provider(): void
     {
         $this->shouldImplement(AssetsProviderInterface::class);

diff --git a/spec/Twig/Locator/LegacyNamespacedTemplateLocatorSpec.php b/spec/Twig/Locator/LegacyNamespacedTemplateLocatorSpec.php
@@ -26,6 +26,11 @@ function let(Filesystem $filesystem): void
         $this->beConstructedWith($filesystem);
     }
 
+    function it_should_trigger_deprecated_warning_during_instantiation(): void
+    {
+        $this->shouldTrigger(\E_USER_DEPRECATED)->duringInstantiation();
+    }
+
     function it_implements_resource_locator_interface(): void
     {
         $this->shouldImplement(TemplateLocatorInterface::class);