Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding container setup #59

Closed
4c0n opened this issue Jul 10, 2020 · 4 comments
Closed

Adding container setup #59

4c0n opened this issue Jul 10, 2020 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@4c0n
Copy link
Contributor

4c0n commented Jul 10, 2020

For development it would be very nice to have a Dockerfile to be able to build some containers for Sylius with the theme installed.
That way we have an integrated toolchain and all the other advantages of running in containers.

My suggestion is to re-use the setup from Sylius-Standard for a big part and pre-install the theme.

@4c0n 4c0n mentioned this issue Jul 10, 2020
@pocky
Copy link
Collaborator

pocky commented Jul 13, 2020

Big 👍 for this.
This dockerfile should be in SkeletonPlugin and Sylius-Standard too 😄

@pocky pocky added the help wanted Extra attention is needed label Jul 14, 2020
@4c0n
Copy link
Contributor Author

4c0n commented Jul 14, 2020

No worries I can take care of this. Just need a little time :)

@anthid
Copy link
Contributor

anthid commented Jul 14, 2020

I can help too. But I think we need some changes in Behat code to be able to run tests against Bootstrap theme, isn't it?

@4c0n
Copy link
Contributor Author

4c0n commented Jul 14, 2020

@anthid It should be a separate issue, but you currently are right about that. I opened this issue: Sylius/Sylius#11622

There is also an example included of the way I currently work around that for plugins. I feel pretty confident that we can make it work, maybe it won't be as big of an issue in this case as we just want to run the tests against the theme, not against the standard ui and the theme. If some selectors aren't using the new testing attributes, then we can open PR's and convert the way the element is selected, it's migrating to that anyway, so I'm sure we'll only produce smiles that way ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants