-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow string in 'root_sass' configuration #54
Allow string in 'root_sass' configuration #54
Conversation
Update: still think the documentation / recipes should contains the array version, as it's easier to understand that multiple values are allowed, and how to add them :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easy win, thanks!
still think the documentation / recipes should contains the array version, as it's easier to understand that multiple values are allowed, and how to add them
Why not use both? :) I think we can show "string" example first (as it will fit most users), but below mention you can specify more values with an array. Wdyt?
Of course, even better :) Just anticipated issues/requests "how can i use multiple pathes" elsewhen :) |
@bocharsky-bw, @smnandre, I update my PR #52 to update the docs with the array version :) |
Thank you! |
I just discover this could be written in a cleaner / shorter way:
CF: https://symfony.com/doc/current/components/config/definition.html#array-nodes Should i update the code ? |
@smnandre I can do it you don't mind? |
Of course you can :) |
the PR is here: #55 |
Allow both string and array to configure
root_sass
. (follows discussion hereMagic done in the dependency extension, so it does not impact any domain code