Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update section Source Sass file in the documentation #52

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

makraz
Copy link
Contributor

@makraz makraz commented Jan 1, 2024

the current yaml snippet in the section Source Sass file throws the error in the screenshot

image

the correct yaml snippet is:

symfonycasts_sass:
  root_sass:
   - 'assets/styles/app.scss'

@smnandre
Copy link
Contributor

smnandre commented Jan 1, 2024

I would have kept the first line (symfonycast_sass)

I’d find the DX easier with the syntax from the doc… maybe can this string -> array be done in the dependency extension ?

doc/index.rst Outdated Show resolved Hide resolved
@bocharsky-bw
Copy link
Member

I’d find the DX easier with the syntax from the doc… maybe can this string -> array be done in the dependency extension ?

This is an interesting idea... and it would improve DX I think. Any volunteer to give it a try?

@smnandre
Copy link
Contributor

smnandre commented Jan 2, 2024

I’d find the DX easier with the syntax from the doc… maybe can this string -> array be done in the dependency extension ?

This is an interesting idea... and it would improve DX I think. Any volunteer to give it a try?

#54

Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on this docs! Thank you guys for working on it :)

@bocharsky-bw bocharsky-bw merged commit 7871b49 into SymfonyCasts:main Jan 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants