-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CompilerPass with priority to TestKernel #77
Comments
You can create a compatibility layer by using |
Hey, while working on the implementation, I realized that we have our own layer for adding compiler passes to the kernel. It's actually simpler than I initially thought. Take a look at #88 |
Hi @chapterjason, Thank you for working on this. Sadly, I don't exactly know, where I needed this feature, since I worked with a lot of bunches of code during that time. But AFAIR: It looks familiar to my workaround from the past, so that my original problem should be solved with that change. |
Currently, you cannot set the
$priority
argument ofContainerBuilder::addCompilerPass();
when adding aCompilerPass
to theTestKernel
. In a few cases, this is needed, e.g. to run after another CompilerPass which alters the container (in my case: I am developing a bundle providing a custom translator implementation, before we can alter the translator in the pass of the bundle, the CompilerPass of theFrameworkBundle
, which configures the Translator, must have ran).I see these possibilities here:
I am willing to work on this, but I am not sure, which way shall I choose.
The text was updated successfully, but these errors were encountered: