-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand ComponentInstance:definition cardinality to support libraries #31
Comments
Hi Jake, Is the functionality you need in essence the ability to say "choose exactly If so I would prefer to leave this cardinality 1:1 and I can expand upon Matthew Matthew
|
Hi, I agree with Matthew that we need to be careful with cardinality changes. The cardinality change on Sequences for ComponentDefinition had a number of unintended consequences. I would need to see more details though of Matthew’s proposal to know whether or not it is a better approach though. Chris
|
A third possibility is that we could allow Collection to be a target of both ComponentInstance and Module definitions (thereby allowing choice at a functional level as well). Or perhaps create a Choice class as a child of Modules? Here are some use cases that I'm thinking about, all of which need to be served:
|
I think this might work. Namely, you are suggesting that the Definition field of ComponentInstance and Module be allowed to point to a Collection. I would assume these Collections would be required to only include ComponentDefinitions and ModuleDefinitions, respectively. We could perhaps do the same thing for the sequence element of ComponentDefinition. This would make it clear in all cases when we have the simpler fixed option while allowing for the flexibility of higher cardinality in the use cases that require it.
|
I suppose that the advantage of this over just allowing higher cardinality is that it gives us a point off which one might hang additional description of the choice being made. For example, "choose one" assembly from a library is different than realizing a set of permutations. Does that match your understanding as well, Matthew? |
At first sight, combinatorial design is a different problem from specifying M On 18 September 2015 at 15:10, Jacob Beal notifications@github.com wrote:
Dr Matthew Pocock Integrative Bioinformatics Group, School of Computing Science, Newcastle gchat: turingatemyhamster@gmail.com |
I'm don't have any clear proposal for which we do and which we don't cover; I just think these are all frequent use cases that we should keep in mind, such that we end up deliberately choosing to cover or not cover each. |
I agree Jake, combinatorial designs are very, very common, and it would be The semantics of the ComponentDefinition -> child component relationship is There are terms in CHEBI for e.g. a +2 ion. Then this has more specific The issue with DNA combinatorial design is that often the parts you are Thinking about it a bit more, I can imagine wanting to state that all of a This is the best plan I can come up with on short notice without talking to Matthew On 21 September 2015 at 16:53, Jacob Beal notifications@github.com wrote:
Dr Matthew Pocock Integrative Bioinformatics Group, School of Computing Science, Newcastle gchat: turingatemyhamster@gmail.com |
The current SEP document does allow for a sampling strategy which we'd find very useful; what isn't clear from the SEP is whether this sampling allows weights per component or whether it assumes uniformity? |
Isn't this addressed by the combinatorial extension @jakebeal? Can we close this one? |
Yes: library support is implemented with the combinatorial extension, superseding this suggestion. |
We need a way of supporting library constructions, e.g., "tune by assembling this construct using these 10 promoter variants x these 8 5'UTR variants". Right now, we don't have a good way of doing this.
I believe that a simple way to support this is by allowing the ComponentInstance "definition" property to have an unrestricted cardinality rather than a cardinality restricted to precisely 1.
The text was updated successfully, but these errors were encountered: