Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting cross_attn_{i+1}_d{1} but not cross_attn_{i+1}_d{j} on purpose or typo in id_module.py? #25

Open
yuliangguo opened this issue Jun 11, 2024 · 0 comments

Comments

@yuliangguo
Copy link

Dear author,

When I dig deeper into the code, I found this rather confusing. The iterature seems to repeated create d{1} rather than d{j}. Would like to confirm is this setup on purpose or a typo?

https://github.com/SysCV/idisc/blob/5d6cea2f0e5236701b2dfd6dac89cde13a328d33/idisc/models/id_module.py#L180C1-L181C1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant