fix(templatetags): limit menu visibility + missing page id key = crash #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix that if any menu item does not have a
reverse_id
*†, thenlimit_visibility_in_menu.py
will crash.If a CMS page has no ID* set, it will still have a
reverse_id
, it's just blank. This fixes edge case of menu item not having the attr/key.†* I.e. an "ID" in Advanced Settings.
† E.g. CMS News category or article.
Related
Changes
reverse_id
before using itTesting
UI
N/A