fix(templatetags): limit visibility + cms news = crash #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CMS News menu children do/can not have a reverse_id. So when limit_visibility_in_menu looked for it, fatal error.
wesleyboar
deleted the
hotfix/conflict-with-cms-news-and-limit-visitbility-in-menu
branch
wesleyboar
added a commit
to TACC/Core-CMS-Custom
that referenced
this pull request
Dec 6, 2022
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
Dec 6, 2022
jarosenb
added a commit
to TACC/tup-ui
that referenced
this pull request
Jan 27, 2023
* feat(tup-cms): blog/news settings Step 1 of "How to Install DjangoCMS Blog i.e. News". https://github.com/TACC/Core-CMS/wiki/How-to-Install-DjangoCMS-Blog-i.e.-News * fix(tup-cms): blog/news settings (missing import) Step 1 of "How to Install DjangoCMS Blog i.e. News". https://github.com/TACC/Core-CMS/wiki/How-to-Install-DjangoCMS-Blog-i.e.-News * fix(tup-cms): blog/news urls (i forgot this) * fix(templatetags): limit visibility + cms news = ☠ Loads TACC/Core-CMS#571. * fix(tup-cms): full-height edit plugin inside text TACC/Core-CMS#573 * feat(tup-cms): new c-card and o-section * feat(core-cms/styles): .o-section as .section * feat(tup-cms): Style plugin choices - add card(-...) - add o-section--style-muted - add section(-...) * feat(core-styles): many c-card fixes and updates * feat(core-styles): c-data-list & data-list This is atop the card & section patterns I've been installing/updating. * feat(tup-cms): responsive video embed templates * feat(tup-cms): responsive video embed, for real... Last image did not have the code. I had forgotten to merge main. * test(tup-cms): noop, core-cms dev/tup-cms image * feat(core-cms): custom media multimedia blog posts TACC/Core-CMS#582 * test(tup-cms): "hotjar" heatmap analytics script Trying this out before buying. Hopefully it works behind VPN. * fix(core-cms): blog multimedia post setting typo * Revert "test(tup-cms): "hotjar" heatmap analytics script" This reverts commit 8360c91. * fix(tup-cms): latest cms news This deploy lets me delete a snippet. * fix(core-styles): c-card updates (via dev/tup-cms) * feat(core-styles): base, cms, docs, portal re-org (#105) * fix: undo ad-hoc change cuz #106 does it right * chore(core-styles): update to latest Core-Styles was installed at dev/tup-cms--task/core-styles-base-cms-docs-portal-cleanup, but that was merged in TACC/Core-Styles#101. * chore(core-styles): pin to latest (noop) * chore(tup-cms): core-cms image at dev/tup-cms Get a new CMS image (since merge of TACC/Core-CMS#586, i.e. fd64868, and TACC/Core-Styles#102). This new image is built off of TACC/Core-CMS#581 branch. * feat(tup-cms): cmd news (#77) * feat(tup-cms): update & demo major patterns (#97) * fix(core-styles+tup-cms): ui demo fixes * chore(tup-cms): comment about order-based news/blog install * fix(core-styles): no .card in portal nor modals Only necessary because TicketHistory brought `Card` from Reactstrap which SHOULD INSTEAD be a details/summary element, but making details/summary work in TypeScript (or even React) is slower than the CSS selector tweak this brings. --------- Co-authored-by: Jake Rosenberg <jrosenberg@tacc.utexas.edu>
wesleyboar
added a commit
to TACC/Core-CMS-Custom
that referenced
this pull request
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The CMS News menu children do/can not have a
reverse_id. So whenlimit_visibility_in_menu.pylooks for it in one of those, a fatal error occurs.Related
I found the bug while implementing CMS News on TUP.
Changes
reverse_idbefore using itTesting
UI