Skip to content

feat: TUP-553 redesign news article byline#765

Merged
wesleyboar merged 4 commits intofeat/tup-584-news-metadatafrom
feat/tup-553-change-byline-design
Dec 14, 2023
Merged

feat: TUP-553 redesign news article byline#765
wesleyboar merged 4 commits intofeat/tup-584-news-metadatafrom
feat/tup-553-change-byline-design

Conversation

@wesleyboar
Copy link
Copy Markdown
Member

@wesleyboar wesleyboar commented Dec 13, 2023

Overview

Redesign the byline for news articles.

Related

Changes

  • removed custom translation for byline
  • removed byline prefix from UI
  • tweaked template comments for byline

Testing

  1. Open News article and News list.
  2. Verify that the byline on both pages:
    1. does not have "by:" (nor "by")
    2. does have author name
    3. markup has "by" before author name
  3. Verify that the byline on list page:
    1. is right-aligned to the right of date
  4. Verify that the byline on article page:
    1. is left-aligned underneath date

UI

list page article page
list page article page

@wesleyboar wesleyboar changed the base branch from main to feat/tup-584-news-metadata December 13, 2023 23:55
@wesleyboar wesleyboar marked this pull request as ready for review December 14, 2023 16:17
@wesleyboar wesleyboar merged commit 7ab4b5c into feat/tup-584-news-metadata Dec 14, 2023
@wesleyboar wesleyboar deleted the feat/tup-553-change-byline-design branch December 14, 2023 16:18
wesleyboar added a commit that referenced this pull request Dec 14, 2023
* feat: TUP-553 redesign news article byline (#765)

* feat: TUP-553 hide byline prefix

* docs: TUP-553 simpler byline comments

* feat: TUP-553 new byline layout

* feat: TUP-553 new byline layout, page vs list

* fix: social media icons have extra whitespace
wesleyboar added a commit that referenced this pull request Mar 15, 2024
* feat: TUP-553 redesign news article byline (#765)

* feat: TUP-553 hide byline prefix

* docs: TUP-553 simpler byline comments

* feat: TUP-553 new byline layout

* feat: TUP-553 new byline layout, page vs list

* feat: TUP-568 redesign news article date (#767)

* feat: TUP-568 new date layout, split date and byline

* fix: TUP-568 revert published text change (diff ticket will do this)

* fix: TUP-568 revert social icons whitespace fix (diff PR will do this)

* Feat/tup 568 change date design (#772)

* feat: TUP-568 new date layout, split date and byline

* fix: TUP-568 revert published text change (diff ticket will do this)

* fix: TUP-568 revert social icons whitespace fix (diff PR will do this)

* feat: TUP-568 match design of time, cleanup organizational comments

* fix: c-tag styles

* test: ⚠️ incomplete usage of Texasscale's styles

* feat: tup-590 redesign share links (#814)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant