Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change action colors by context, not …on-dark/light vars #137

Merged
merged 7 commits into from
Mar 3, 2023

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Mar 3, 2023

Overview

  • Deprecate --global-color-link-on-dark… & --global-color-link-on-light….
  • New feature to change accent colors depending on context via generics/color.css.
  • Fix button on dark section to use light accent colors.

Related

None.

Changes

  • abandoned & deprecated --global-color-accent-on-light… and --global-color-accent-on-dark….

  • added generics/color.css to manage color change on dark and light

  • added new color --global-color-accent--xxx-light (#f1ebfd)

  • re-built affected patterns
    • components
      • admonition
      • button
      • callout
      • form
      • message
      • recognition
    • elements
      • links
    • objects
      • section
    • tools
      • x-links
    • trumps
      • links (irregular)

Testing & UI

Extended Testing: Verify global accent colors are only overwritten in dark context and in light contexts within dark contexts.

section.buttons.mov

Sections

light muted dark
light section buttons muted section buttons dark section buttons

Button Types

primary secondary tertiary
button primary button secondary button tertiary

Cards

(default) plain standard standard 1 standard 2 standard 3
card (default) card plain card standard card standard 1 card standard 2 card standard 3

Internal Clients

form django cms form messages
form django cms form messages

Links

mixin irregular standard
link (mixin) links (irregular) links

Notes

Known Issues

  1. There is unnecessary duplication of light context accent colors:
    1. settings/color.css
    2. generics/color.css

Ideas

  1. Expand on this to support dark and light theme, or white-labelling, or clearer color customization process.
  2. Can https://github.com/csstools/postcss-plugins eliminate "Known Issue" Initial Release #1?

- Deprecate --global-color-link-on-dark… & --global-color-link-on-light…
- Change accent colors depending on context.
@wesleyboar wesleyboar changed the title feat: deprecate --…color-link-on-… with context feat: change action colors by context, not …on-dark/light vars Mar 3, 2023
@wesleyboar wesleyboar force-pushed the bugfix/light-button-on-dark-context branch from 4f3ad9a to 631eb39 Compare March 3, 2023 21:35
@wesleyboar wesleyboar marked this pull request as ready for review March 3, 2023 21:36
@wesleyboar wesleyboar added the fix Fixes user-facing behavior or feature label Mar 3, 2023
@wesleyboar wesleyboar merged commit c767bc5 into main Mar 3, 2023
@wesleyboar wesleyboar deleted the bugfix/light-button-on-dark-context branch March 3, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes user-facing behavior or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant