Item B-03902: As a curator, I would like to see all the metadata, even for unassociated schemata #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n for unassociated schemata The unassociated schemata are being added in the properties as other approaches likely involve changes to the API.
kaladay
requested review from
jcreel,
jeremythuff,
jsavell,
a user and
rladdusaw
|
Looks like I see a problem, I mis-read the logic of the if-conditional and didn't consider properties that may already be added. |
Added additional logic to break out of loops once found.
ghost
approved these changes
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unassociated schemata are being added in the properties as other approaches likely involve changes to the API.
This is the simplest approach to solving the card as closely as possible without API changes.