Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint5 staging #93

Merged
merged 53 commits into from May 28, 2020
Merged

Sprint5 staging #93

merged 53 commits into from May 28, 2020

Conversation

jcreel
Copy link
Member

@jcreel jcreel commented May 28, 2020

No description provided.

kaladay and others added 30 commits April 24, 2020 10:49
Refactor Project to Product
Maintain existing end-point for submitting FeatureRequest, unchanged.
The FeatureRequest is then converted into an InternalRequest and stored in the database.
The product end-point no longer performs push and instead new end-points are created under `/internal/request/` to perform the push.
This new end-point `/internal/request/` includes CRUD operations.

The new push end-point `/internal/request/push` will convert the InternalRequest to a FeatureRequest before pushing.
This ensures that any service outside of Product Management System will only know about FeatureRequest and do not need to be aware of InternalRequest in any manner.
From the point of view of services outside of Product Management System, Product Management System receives a FeatureRequest and pushes a FeatureRequest.
Issue 62: Store LSSS requests in an internal queue
…harvest

Including open organization projects in active sprint list
Update tests and fix revealed problems
[MERGER] Issues 61, 62: Internal Queue and multiple ProjectManagementSoftware URIs
kaladay and others added 23 commits May 11, 2020 16:12
Refactor remoteProducts where remoteProducts is actually remoteProductInfo
Issue 65: Add internal requests stats count
Fixed sprint update issue and validating urls
Always associate the product received by remote products such as LSSS.
This requires redesigning the Service and UI to associate with a given product.
Whereas before, the product was only associated on push, the product is now associated on create/edit.
This includes fixing the URL.
Remote Projects should not be under the Product URL.

A new controller is brought in for providing `/projects/remote/by-product/{productId}`.

Fetching all remote projects was moved out of the `/products` URL and into the `/remote-project-manager` URL as follows:
- `/remote-project-manager/{remoteProjectManagerId}/remote-projects`
- `/remote-project-manager/{remoteProjectManagerId}/remote-projects/{scopeId}`
Follow up on changes to internal cards, stats
This needs further discussion.
Refactor Remote Products to Remote Projects
@jcreel jcreel merged commit e9fd033 into master May 28, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 372

  • 338 of 353 (95.75%) changed or added relevant lines in 25 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 95.015%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/edu/tamu/app/ProductApplication.java 2 3 66.67%
src/main/java/edu/tamu/app/service/manager/VersionOneService.java 20 21 95.24%
src/main/java/edu/tamu/app/controller/ProductController.java 50 53 94.34%
src/main/java/edu/tamu/app/model/InternalStats.java 7 11 63.64%
src/main/java/edu/tamu/app/model/InternalRequest.java 15 21 71.43%
Files with Coverage Reduction New Missed Lines %
src/main/java/edu/tamu/app/model/request/FeatureRequest.java 2 83.33%
Totals Coverage Status
Change from base Build 270: -0.4%
Covered Lines: 1277
Relevant Lines: 1344

💛 - Coveralls

@kaladay kaladay deleted the sprint5-staging branch September 17, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants