Add DidJwk and update other DID methods #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
✅ Deploy Preview for tbd-website-developer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks for starting this! This is good to see ahead of time! |
angiejones
reviewed
Feb 7, 2024
site/code-snippets/web5/build/verifiable-credentials/vc-issuance.js
Outdated
Show resolved
Hide resolved
* Issue #1197 - Add tbdex-kt dependencies to Kotlin TestSuite With a WHOLE LOT of Dark Arts Evil Nonsense to make it work: * SNAPSHOT dependency * Addition of a SNAPSHOTs repo * dependencyManagement to force version resolution This may unblock us temporarily but will not work sustainably. The SNAPSHOT dependency will go away and due to version changes from upstream projects the dependencyManagement guards will need to be updated with them.
* Kotlin: PFI Allowlist * dont publish test dids * ocd
* kotlin shnips * adding new line * kotlin shnip wasnt generating * removing extra code snippet * enabling switch content * adding clarity for presentation submission with Kotlin * showing language switcher at the top * adding back title * adding back title * hardcode imports * make verifiable presentation more obvious * put language switcher at the top * remove unnnecessary import * possible note for missing method * PR #1199 - Fix jackson.core to a more compatible version * handle all imports with model.* * add in as snippet --------- Co-authored-by: Andrew Lee Rubinger <alr@alrubinger.com>
* add replyTo option for RFQs * Update site/docs/tbdex/wallet/send-rfq.mdx Co-authored-by: Angie Jones <jones.angie@gmail.com> --------- Co-authored-by: Angie Jones <jones.angie@gmail.com>
* Fan Club VC with Kotlin snippets * wrapping in a try catch
…icate failure (#1210) tweak a few badges to avoid yellow, orange colors this will make failures/warnings more obvious
* Presentation Definition kotlin updates * Fix tests * removed submission requirements * aligned validation snippets --------- Co-authored-by: angiejones <jones.angie@gmail.com>
* Use shnip system, still need code snippets for some parts of exchanges and offerings apis pending convo with Jiyoon * add all snippets * Update snippet names and use Shnip system * fixing code * add Kotlin code snippets * update js server name * update tests to run out of new testsuites directories * renaming kotlin test file * Update Kotlin code * Use shnip system, still need code snippets for some parts of exchanges and offerings apis pending convo with Jiyoon * add all snippets * Update snippet names and use Shnip system * fixing code * add Kotlin code snippets * update js server name * update tests to run out of new testsuites directories * renaming kotlin test file * Update Kotlin code * Make io.ktor.server available on the classpath * Try to fix Kotlin compilation errors * try to fix build * conforming title to the rest of the guides on the site * pushing up some changes, still addressing comments * separate out Kotlin classes * fix build issue with package names * fix build * update PFI did creation, sync names of sever var * Apply suggestions from code review Apply suggestions Co-authored-by: Angie Jones <jones.angie@gmail.com> * add imports * removing dup imports --------- Co-authored-by: Angie Jones <jones.angie@gmail.com> Co-authored-by: Andrew Lee Rubinger <alr@alrubinger.com>
* switching to Shnips in JWT to VC * add headers * fix path
* first push for orders page to write snippets * fix kotlin snippet and imports * update markdown * Adding Close Message snippets * fixed js Close snippet * address comments to resolve them, still need to test after wiping out most of them * missing js ordermessage rename * add language links --------- Co-authored-by: Rizel Scarlett <rizel@tbd.email> Co-authored-by: angiejones <jones.angie@gmail.com>
* Wallet: Get Offerings - js/kt * added mock server and tests for Kotlin * test data * JS mock PFI server and tests
acekyd
requested review from
dayhaysoos,
EbonyLouis and
leordev
as code owners
angiejones
reviewed
Feb 20, 2024
| @@ -18,7 +18,18 @@ export async function getDwnEndpoints() { | |||
| const serviceEndpointNodes = await getTechPreviewDwnEndpoints(); | |||
|
|
|||
| // generates key pairs used for authorization and encryption when interfacing with DWNs | |||
| const didOptions = await DidIonMethod.generateDwnOptions({ serviceEndpointNodes }); | |||
| const didOptions = { | |||
| keySet: { | |||
There was a problem hiding this comment.
why do these need to be explicitly defined vs a default set provided by the SDK?
There was a problem hiding this comment.
The generateDwnOptions method was removed entirely. In conversation with Moe on what the alternative is, and will update once available.
There was a problem hiding this comment.
@frankhinek the dev shouldn't have to do this right? how do we get around it?
angiejones
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR:
@web/didspackageDidxxxMethodimports to use the newly updated implementations withDidxxxAs a result of the
@web5/didspackage update, the following are pending or currently broken and I need more information to fix.DidIonMethodusesgenerateDwnOptions()which no longer exists onDidIonand I can't find the substitute for it..toKeys()doesn't currently work in Kotlin to get the Keysets.Added code snippets?
Added tests?
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?