Kotlin: PFI Allowlist #1208
Merged
Kotlin: PFI Allowlist #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angiejones
requested review from
dayhaysoos,
EbonyLouis and
leordev
as code owners
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
✅ Deploy Preview for tbd-website-developer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chris-tbd
approved these changes
Feb 6, 2024
| @@ -1,7 +1,14 @@ | |||
| --- | |||
| title: Allowlisting PFIs | |||
| hide_title: true | |||
There was a problem hiding this comment.
I think we want to show title, otherwise the language switcher goes above the title and it looks kind awkward
There was a problem hiding this comment.
we want it above the title. you think it looks weird? i thought it looked weird inline with content
| class PfiAllowListTest { | ||
|
|
||
| @Test | ||
| fun `check if DID has PFI service`() { |
There was a problem hiding this comment.
Do we have all this setup that we can use from another test file, and then just add this snippet in? Or do we have to duplicate this code?
There was a problem hiding this comment.
i think we may be able to once @dayhaysoos adds his changes
ALRubinger
force-pushed
the
allowlist-kotlin
branch
from
8cd2ab3
to
0ba978c
Compare
blackgirlbytes
pushed a commit
that referenced
this pull request
Feb 7, 2024
* Kotlin: PFI Allowlist * dont publish test dids * ocd
acekyd
pushed a commit
that referenced
this pull request
Feb 12, 2024
* Kotlin: PFI Allowlist * dont publish test dids * ocd
acekyd
added a commit
that referenced
this pull request
Feb 20, 2024
* Add DidJwk and update other DID methods * Issue #1197 - Add tbdex-kt dependencies (PR #1198) * Issue #1197 - Add tbdex-kt dependencies to Kotlin TestSuite With a WHOLE LOT of Dark Arts Evil Nonsense to make it work: * SNAPSHOT dependency * Addition of a SNAPSHOTs repo * dependencyManagement to force version resolution This may unblock us temporarily but will not work sustainably. The SNAPSHOT dependency will go away and due to version changes from upstream projects the dependencyManagement guards will need to be updated with them. * nuxt transpile error doc (#1200) * Kotlin: PFI Allowlist (#1208) * Kotlin: PFI Allowlist * dont publish test dids * ocd * Added Kotlin Shnips for PEX (#1199) * kotlin shnips * adding new line * kotlin shnip wasnt generating * removing extra code snippet * enabling switch content * adding clarity for presentation submission with Kotlin * showing language switcher at the top * adding back title * adding back title * hardcode imports * make verifiable presentation more obvious * put language switcher at the top * remove unnnecessary import * possible note for missing method * PR #1199 - Fix jackson.core to a more compatible version * handle all imports with model.* * add in as snippet --------- Co-authored-by: Andrew Lee Rubinger <alr@alrubinger.com> * Removing sidebar link to JS API Guide (#1211) * Issue #1197 - Update to locked tbdex-kt:0.9.0-beta off former SNAPSHOT * add replyTo option for RFQs (#1207) * add replyTo option for RFQs * Update site/docs/tbdex/wallet/send-rfq.mdx Co-authored-by: Angie Jones <jones.angie@gmail.com> --------- Co-authored-by: Angie Jones <jones.angie@gmail.com> * Fan Club VC with Kotlin snippets (#1212) * Fan Club VC with Kotlin snippets * wrapping in a try catch * OSS Project Dashboard: Avoid orange, yellow for badges that don't indicate failure (#1210) tweak a few badges to avoid yellow, orange colors this will make failures/warnings more obvious * Presentation Definition kotlin updates (#1213) * Presentation Definition kotlin updates * Fix tests * removed submission requirements * aligned validation snippets --------- Co-authored-by: angiejones <jones.angie@gmail.com> * Removing console logs (#1217) * update docs with references for KMS (#1216) * Add Kotlin Snippets to PFI/Structuring a PFI App (#1181) * Use shnip system, still need code snippets for some parts of exchanges and offerings apis pending convo with Jiyoon * add all snippets * Update snippet names and use Shnip system * fixing code * add Kotlin code snippets * update js server name * update tests to run out of new testsuites directories * renaming kotlin test file * Update Kotlin code * Use shnip system, still need code snippets for some parts of exchanges and offerings apis pending convo with Jiyoon * add all snippets * Update snippet names and use Shnip system * fixing code * add Kotlin code snippets * update js server name * update tests to run out of new testsuites directories * renaming kotlin test file * Update Kotlin code * Make io.ktor.server available on the classpath * Try to fix Kotlin compilation errors * try to fix build * conforming title to the rest of the guides on the site * pushing up some changes, still addressing comments * separate out Kotlin classes * fix build issue with package names * fix build * update PFI did creation, sync names of sever var * Apply suggestions from code review Apply suggestions Co-authored-by: Angie Jones <jones.angie@gmail.com> * add imports * removing dup imports --------- Co-authored-by: Angie Jones <jones.angie@gmail.com> Co-authored-by: Andrew Lee Rubinger <alr@alrubinger.com> * switching to use Shnip in JWT to VC (#1218) * switching to Shnips in JWT to VC * add headers * fix path * Adding padding on Shnip content (#1219) * Upgrade to xyz.block:tbdex:0.10.0-beta * update merge * PFI/Orders Kotlin Code Snippets (#1220) * first push for orders page to write snippets * fix kotlin snippet and imports * update markdown * Adding Close Message snippets * fixed js Close snippet * address comments to resolve them, still need to test after wiping out most of them * missing js ordermessage rename * add language links --------- Co-authored-by: Rizel Scarlett <rizel@tbd.email> Co-authored-by: angiejones <jones.angie@gmail.com> * Mock PFI Servers (#1223) * Wallet: Get Offerings - js/kt * added mock server and tests for Kotlin * test data * JS mock PFI server and tests * Publish PFI DIDs used for tbDEX * Changed PFI example service endpoints (#1224) * Update DID variable names * Updating tests and snippets * added options to DID create * removing pfi-structure.test.js file, doesnt compile * tbdex version update * fixing tests * remove console.log * formatting * removing DidKey example from Create a DID guide * removing DidKey test * Update import snippets * renaming variables for better readability * update tests --------- Co-authored-by: Andrew Lee Rubinger <alr@alrubinger.com> Co-authored-by: Angie Jones <jones.angie@gmail.com> Co-authored-by: Rizel Scarlett <rizel@tbd.email> Co-authored-by: Finn <139806439+finn-tbd@users.noreply.github.com> Co-authored-by: chris-tbd <129119076+chris-tbd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
testarguments to run browser tests lastDirect link to deploy preview
https://deploy-preview-1208--tbd-website-developer.netlify.app/docs/tbdex/wallet/allowlist-pfis
Mobile & Desktop Screenshots/Recordings
Added code snippets?
Added tests?
Added to documentation?
What gif best describes this PR or how it makes you feel?