Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target Correct CPU architecture with ftl deploy #1845

Open
alec-brooks opened this issue Jun 21, 2024 · 3 comments
Open

Target Correct CPU architecture with ftl deploy #1845

alec-brooks opened this issue Jun 21, 2024 · 3 comments
Labels

Comments

@alec-brooks
Copy link
Contributor

The behaviour of ftl deploy is currently to build FTL modules with the CPU architecture of the system that the FTL cli is running on. This is problematic when building on a device that has a different CPU architecture than the environment where the FTL cluster is running.

Being able to specify the CPU architecture to build for as an argument in ftl deploy and ftl build would likely remediate this.

Though it would be very cool if it was possible for the FTL CLI to ask the running FTL cluster what CPU architecture it has before building so that users don't need to remember to pass in the flag.

@github-actions github-actions bot added the triage Issue needs triaging label Jun 21, 2024
@ftl-robot ftl-robot mentioned this issue Jun 21, 2024
@alecthomas
Copy link
Collaborator

Unfortunately for the general case across languages this would be very difficult, or impossible, to achieve.

@alecthomas
Copy link
Collaborator

OTOH we should definitely reject deploys from a different architecture.

@alec-brooks
Copy link
Contributor Author

Yeah, I see what you mean, it would be very hard to do generically. I think just blocking deploys from other architectures would be a big improvement as right now it is easy to break things accidentally.

@matt2e matt2e added next Work that will be be picked up next P2 and removed triage Issue needs triaging labels Jul 1, 2024
@bradleydwyer bradleydwyer removed the next Work that will be be picked up next label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants