Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWT Sign and Verify updates #190

Closed
nitro-neal opened this issue Jan 17, 2024 · 2 comments
Closed

JWT Sign and Verify updates #190

nitro-neal opened this issue Jan 17, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@nitro-neal
Copy link
Contributor

A few thoughts and updates need to be made to our JWT signing logic:

Sign
// TODO: ensure that publicKeyJwk is not null
// TODO: figure out how to make more reliable since algorithm is technically not a required property of a JWK
verificationMethodId and jwt.header.keyID could be different: for example we may have a key id as a JWK thumbprint but a verification method ID as did:example:abcd#key-1

Verify
Could make a presentation definition where I'm specifically requesting expired credentials. this check would fail, since JWT validation fails if the exp property is in the past

More reference here - #184

@nitro-neal
Copy link
Contributor Author

The only open question now is this:

// TODO: figure out how to make more reliable since algorithm is technically not a required property of a JWK

@jiyoontbd is this going to be irrelevant soon? Is jwt signing / verifying changing?

@jiyoonie9
Copy link
Contributor

@nitro-neal yea, i think so. #262 introduces our own jws + jwt types, and also removes jwtutil altogether, where that todo was recorded.

closing as duplicate of #234 - let me know if you disagree and we can reopen!

@jiyoonie9 jiyoonie9 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

4 participants