Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instructor edit sessions page: Fix add question button overflow #12269

Closed
zhaojj2209 opened this issue Mar 27, 2023 · 6 comments · Fixed by #12477
Closed

Instructor edit sessions page: Fix add question button overflow #12269

zhaojj2209 opened this issue Mar 27, 2023 · 6 comments · Fixed by #12477
Labels
a-UIX User Interface, User eXperience, responsiveness c.Bug Bug/defect report good first issue Easy; restricted for first-time contributors p.Low Very little impact; unlikely to do in the near future

Comments

@zhaojj2209
Copy link
Contributor

At screen widths smaller than 379px, the "Add Question" buttons overflow to the next line.
Screenshot 2023-03-27 at 16 14 18

The same issue exists for the instructor help page, for widths smaller than 411px.
Screenshot 2023-03-27 at 16 15 15

One way to fix this is to reduce the padding between components at smaller screen sizes.
@zhaojj2209 zhaojj2209 added p.Low Very little impact; unlikely to do in the near future good first issue Easy; restricted for first-time contributors c.Bug Bug/defect report labels Mar 27, 2023
@amanx123
Copy link

Assign me so that I can work on this.

@yenniejunvu
Copy link

Hi! I'm a university student who would like to attempt this, and I am new to open source code.

I believe was able to recreate the issue:
recreate_issue

@zhaojj2209
Copy link
Contributor Author

@yenniejunvu Feel free to submit a PR for this issue.

@amanx123 You have already expressed interest in another issue, as such we will give the opportunity to someone else. Also, please be nice, we will not assign you the issue just because you demand to be assigned one.

@zhaojj2209 zhaojj2209 added the a-UIX User Interface, User eXperience, responsiveness label Mar 28, 2023
@nickerick nickerick mentioned this issue May 4, 2023
Closed
@singhabhyudita
Copy link
Contributor

Hi, @yenniejunvu are you working on this one? If not I would like to take up this issue.

@weiquu
Copy link
Contributor

weiquu commented Jun 13, 2023

Hi @singhabhyudita, please feel free to go ahead and submit a PR for this issue

@singhabhyudita
Copy link
Contributor

Sure @weiquu, I'm on it!

This was referenced Jun 16, 2023
Closed
Merged
Closed
domlimm pushed a commit that referenced this issue Jul 2, 2023
@singhabhyudita
[#12269] Instructor edit sessions page: Fix add question button overf…
14dde85 
…low. (#12477)

* fixed overlapping button issue

* Overflow fixed

* Updating failing checks

* Reduced padding at ends and for the info button

* Corresponding snapshots updated

* Padding changed to horizontal axis

* snapshots updated

* custom styling added
Zxun2 pushed a commit to Zxun2/teammates that referenced this issue Jul 12, 2023
@singhabhyudita @Zxun2
[TEAMMATES#12269] Instructor edit sessions page: Fix add question but…
572e352 
…ton overflow. (TEAMMATES#12477)

* fixed overlapping button issue

* Overflow fixed

* Updating failing checks

* Reduced padding at ends and for the info button

* Corresponding snapshots updated

* Padding changed to horizontal axis

* snapshots updated

* custom styling added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-UIX User Interface, User eXperience, responsiveness c.Bug Bug/defect report good first issue Easy; restricted for first-time contributors p.Low Very little impact; unlikely to do in the near future
Projects
None yet
Milestone
No milestone
5 participants
@amanx123 @weiquu @zhaojj2209 @singhabhyudita @yenniejunvu