Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12269] Instructor edit sessions page: Fix add question button overflow. #12476

Closed
wants to merge 2 commits into from
Closed

Conversation

singhabhyudita
Copy link
Contributor

Fixes #12269

Outline of Solution

For screen width less than 411px, I increased the top margin of the buttons.

Here are the changes:

Instructor edit sessions page:
Screenshot 2023-06-16 at 11 50 50 AM

Instructor help page:
Screenshot 2023-06-16 at 11 51 48 AM

Copy link
Contributor

@domlimm domlimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@singhabhyudita Good attempt! Do consider what was suggested in the opening of the issue that you're currently fixing. As TEAMMATES uses a UI library, Boostrap, it is always a good rule of thumb to make use of it. Do look at the documentation for anything that you can make use of to solve the issue instead of creating custom styles that could clutter up the related files in the long run 👍🏻

Also, please ensure that all tests are passing. E2E Tests fails from time to time, not to worry, we'll look at it and re-run if it fails.

@singhabhyudita
Copy link
Contributor Author

@domlimm alright so I should try to use the Bootstrap classes to decrease the padding between buttons as suggested in the opening of the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instructor edit sessions page: Fix add question button overflow
2 participants