Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instructor editing feedback path of a question: unnecessary scrollbars #12399

Closed
damithc opened this issue Apr 20, 2023 · 3 comments · Fixed by #12409
Closed

Instructor editing feedback path of a question: unnecessary scrollbars #12399

damithc opened this issue Apr 20, 2023 · 3 comments · Fixed by #12409
Labels
a-UIX User Interface, User eXperience, responsiveness p.Medium Marginal impact; would like to do if time permits

Comments

@damithc
Copy link
Contributor

damithc commented Apr 20, 2023

v8.27, production, Windows, Chrome

Context: an instructor is editing questions of an existing session

image

image

Let me know if more info needed to reproduce
@damithc damithc added a-UIX User Interface, User eXperience, responsiveness p.Medium Marginal impact; would like to do if time permits labels Apr 20, 2023
@athakaras
Copy link
Contributor

Hello. I am interested in trying this issue. Can you please provide more info on how to find the feedback path both on site and on files? Thanks a lot!

@zhaojj2209
Copy link
Contributor

@athakaras The components in question can be found on the instructor edit sessions page. We recommend following our development guidelines to set up the project on your local device, then exploring the site/codebase to find the relevant components/files on your own.

@athakaras athakaras mentioned this issue Apr 23, 2023
Merged
@athakaras
Copy link
Contributor

Hello! I raised a PR that fixes the issue. Please review :)

domlimm pushed a commit that referenced this issue Apr 29, 2023
@athakaras @jasonqiu212
[#12399] Instructor editing feedback path of a question: unnecessary …
1d21aab 
…scrollbars (#12409)

* Fix issue of unnecessary scrollbars

* Fix snapshot issues

---------

Co-authored-by: Jason Qiu <jason_qiu@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-UIX User Interface, User eXperience, responsiveness p.Medium Marginal impact; would like to do if time permits
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#12399] Instructor editing feedback path of a question: unnecessary scrollbars athakaras/teammates
3 participants
@damithc @zhaojj2209 @athakaras