Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12399] Instructor editing feedback path of a question: unnecessary scrollbars #12409

Merged
merged 4 commits into from
Apr 29, 2023

Conversation

athakaras
Copy link
Contributor

Fixes #12399

Outline of Solution

Fix the issue by removing "overflow-scroll" which was the reason for the unnecessary scrollbars when an instructor is editing a question of an existing session (feedback path)

Here is the updated UI

issue1
issue2

@weiquu
Copy link
Contributor

weiquu commented Apr 23, 2023

Hi @athakaras, fix looks fine but do merge the latest changes from master into your branch and update the failing snapshot tests

@athakaras
Copy link
Contributor Author

Hello! Fixed all issues.
Please review and merge :)

Copy link
Contributor

@zhaojj2209 zhaojj2209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on Linux (since this issue seems to be not present on Mac).

@zhaojj2209 zhaojj2209 added the s.FinalReview The PR is ready for final review label Apr 25, 2023
@weiquu weiquu requested a review from domlimm April 27, 2023 05:19
Copy link
Contributor

@domlimm domlimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution!

@domlimm domlimm added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Apr 29, 2023
@domlimm domlimm merged commit 1d21aab into TEAMMATES:master Apr 29, 2023
7 checks passed
@samuelfangjw samuelfangjw added the c.Bug Bug/defect report label Jul 14, 2023
@samuelfangjw samuelfangjw added this to the V8.28.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instructor editing feedback path of a question: unnecessary scrollbars
6 participants