Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Student viewing results of a contribution question: (i) icon doesn't look clickable #12607

Closed
damithc opened this issue Oct 17, 2023 · 9 comments · Fixed by #12623
Closed

Student viewing results of a contribution question: (i) icon doesn't look clickable #12607

damithc opened this issue Oct 17, 2023 · 9 comments · Fixed by #12623
Labels
a-UIX User Interface, User eXperience, responsiveness p.Medium Marginal impact; would like to do if time permits

Comments

@damithc
Copy link
Contributor

damithc commented Oct 17, 2023

Context: a student is viewing the result of a contribution question.

image

Suggestions:

  1. Make the hover over mouse icon indicate that it is a clickable item
  2. Put a dotted line below it (similar to My View in the screenshot) to show that there is additional content behind the (i) icon.
@damithc damithc added a-UIX User Interface, User eXperience, responsiveness p.Medium Marginal impact; would like to do if time permits labels Oct 17, 2023
@nikkixiong
Copy link

Hi, I am interested in this issue, can I be assigned to this issue?

@github-actions github-actions bot mentioned this issue Oct 17, 2023
Open
@cedricongjh
Copy link
Contributor

hey @nikkixiong, feel free to submit a PR for this!

@anjum-edge

This comment was marked as spam.

Sign in to view
@Jiaqi093
Copy link
Contributor

Hi, may I be assigned to this issue?

@Zhouheng98
Copy link

Hi, I am a student, can I try to solve this problem?

@cedricongjh
Copy link
Contributor

hi @Jiaqi093 and @Zhouheng98, let's give @nikkixiong time to submit a PR

@nikkixiong do let us know if you're still working on this, thank you!

@Jiaqi093 Jiaqi093 mentioned this issue Oct 26, 2023
Merged
@Jiaqi093
Copy link
Contributor

Hi, I just submit a PR, could you please review it?

@saurabhje
Copy link

If its still not fixed let me know.

@cedricongjh
Copy link
Contributor

hi @saurabhje there's already an open PR for this issue, you're welcome to find other issues to contribute to

weiquu added a commit that referenced this issue Dec 4, 2023
@Jiaqi093 @weiquu
[#12607] add mouse hover and add dotted line to the icon (#12623)
21c8835 
* solve the 12607 issue, put mouse hover and add dotted line to the icon

* solve the 12607 issue, put mouse hover and add dotted line to the icon

* solve the 12607 issue, put mouse hover and add dotted line to the icon

---------

Co-authored-by: Wei Qing <48304907+weiquu@users.noreply.github.com>
cedricongjh pushed a commit to cedricongjh/teammates that referenced this issue Feb 20, 2024
@Jiaqi093 @weiquu @cedricongjh
[TEAMMATES#12607] add mouse hover and add dotted line to the icon (TE…
3886950 
…AMMATES#12623)

* solve the 12607 issue, put mouse hover and add dotted line to the icon

* solve the 12607 issue, put mouse hover and add dotted line to the icon

* solve the 12607 issue, put mouse hover and add dotted line to the icon

---------

Co-authored-by: Wei Qing <48304907+weiquu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-UIX User Interface, User eXperience, responsiveness p.Medium Marginal impact; would like to do if time permits
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#12607] add mouse hover and add dotted line to the icon Jiaqi093/teammates
7 participants
@damithc @anjum-edge @cedricongjh @Jiaqi093 @saurabhje @Zhouheng98 @nikkixiong