Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12607] add mouse hover and add dotted line to the icon #12623

Merged
merged 4 commits into from
Dec 4, 2023
Merged

[#12607] add mouse hover and add dotted line to the icon #12623

merged 4 commits into from
Dec 4, 2023

Conversation

Jiaqi093
Copy link
Contributor

@Jiaqi093 Jiaqi093 commented Oct 26, 2023 •
edited
Loading

Fixes #12607.

Outline of Solution

for the student login page, I have added the mouse hover feature and dotted line below the "i" icon in the question 11, that is comparison of Work distribution. I basically update the styles.css, which can be find at the end of the file.
1698303758215

@github-actions
Copy link

Hi @Jiaqi093, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

2 similar comments
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 11 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 9 days). 🐌 😢
Hope someone can get it to move forward again soon...

weiquu
weiquu approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weiquu weiquu merged commit 21c8835 into TEAMMATES:master Dec 4, 2023
9 checks passed
@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Feature User-facing feature; can be new feature or enhancement to existing feature labels Jan 21, 2024
@wkurniawan07 wkurniawan07 added this to the V8.30.0 milestone Jan 21, 2024
cedricongjh pushed a commit to cedricongjh/teammates that referenced this pull request Feb 20, 2024
@Jiaqi093 @weiquu @cedricongjh
[TEAMMATES#12607] add mouse hover and add dotted line to the icon (TE…
3886950 
…AMMATES#12623)

* solve the 12607 issue, put mouse hover and add dotted line to the icon

* solve the 12607 issue, put mouse hover and add dotted line to the icon

* solve the 12607 issue, put mouse hover and add dotted line to the icon

---------

Co-authored-by: Wei Qing <48304907+weiquu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiquu weiquu weiquu approved these changes

@jasonqiu212 jasonqiu212 Awaiting requested review from jasonqiu212

Assignees
No one assigned
Labels
c.Feature User-facing feature; can be new feature or enhancement to existing feature s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.30.0
Development

Successfully merging this pull request may close these issues.

Student viewing results of a contribution question: (i) icon doesn't look clickable
4 participants
@Jiaqi093 @nusoss-bot @weiquu @wkurniawan07