Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructor's Student Records Page: Tooltips for comments #12663

Closed
weiquu opened this issue Dec 16, 2023 · 1 comment · Fixed by #12676
Closed

Instructor's Student Records Page: Tooltips for comments #12663

weiquu opened this issue Dec 16, 2023 · 1 comment · Fixed by #12676
Labels
a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors

Comments

@weiquu
Copy link
Contributor

weiquu commented Dec 16, 2023

Mousing over the tooltips for instructor comments causes the text to go into the next line, which can be jarring for the user. Here is the normal view:
normal view

Here is the view when a user mouses over the first tooltip:
on tooltip 1

And here is the view when a user mouses over the second tooltip:
on tooltip 2

Notice how the words/image move to the next line.

While addressing this issue, do also try to address the following:

  • The visibility eye icon should have dotted lines under it as well, to indicate that users can mouse over for more information. Not sure if the icon itself is clear enough to indicate that the info is about visibility - feel free to suggest alternatives
  • When a comment has been edited, the screen reader reads the first line ("Instructor commented at 16 Dec 4:37pm") twice. Not sure what is causing it, possibly some wrapping of the elements. Do take a look into this as well, but we can shift to another issue if needed
@weiquu weiquu added a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors labels Dec 16, 2023
Copy link

Good First Issue - Notes for Contributors
This issue is for first-time contributors only. If you are new to TEAMMATES, feel free to submit a PR for this issue.

Please note that we allow only one good first issue per contributor. If you have already made a prior contribution to TEAMMATES, you may wish to take a look at issues with the help wanted tag instead.

We do not assign issues to contributors. If you would like to pick up this issue, do post a comment below to express your interest and check if there is anyone else who is already working on the issue. We will do our best to reply and give you the go-ahead, but if we don't, feel free to submit a PR as long as there is no one else working on it.

To get started, do read through our contributing guidelines carefully, and set up a development environment on your local machine before making a PR.

If you need any clarifications on our developer guide, or are facing issues that are not found in our troubleshooting guide, please post a message in our discussion forum.

domlimm added a commit that referenced this issue Dec 28, 2023
…2676)

* Fix comment tooltip causing the text to go into next line

* Update snapshot test

---------

Co-authored-by: YX Z <yxz@YXs-MacBook-Air-2.local>
Co-authored-by: Wei Qing <48304907+weiquu@users.noreply.github.com>
Co-authored-by: Dominic Lim <46486515+domlimm@users.noreply.github.com>
Co-authored-by: Jason Qiu <jason_qiu@hotmail.com>
cedricongjh pushed a commit to cedricongjh/teammates that referenced this issue Feb 20, 2024
…ments (TEAMMATES#12676)

* Fix comment tooltip causing the text to go into next line

* Update snapshot test

---------

Co-authored-by: YX Z <yxz@YXs-MacBook-Air-2.local>
Co-authored-by: Wei Qing <48304907+weiquu@users.noreply.github.com>
Co-authored-by: Dominic Lim <46486515+domlimm@users.noreply.github.com>
Co-authored-by: Jason Qiu <jason_qiu@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant